feat: make load_credentials_from_file a public method
#530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
…brary-python into support-scopes
google/auth/_default.py
Outdated
Comment on lines
140
to
145
| raise exceptions.DefaultCredentialsError( | ||
| "The file {file} does not have a valid type. " | ||
| "Type is {type}, expected one of {valid_types}.".format( | ||
| file=filename, type=credential_type, valid_types=_VALID_TYPES | ||
| ) | ||
| ) |
There was a problem hiding this comment.
The control flow is a little tricky to eyeball grep. It may be easier if it were changed to be something like
if credential_type is None:
raise exceptions.DefaultCredentialsError(...)
# dedented control flow
Merged
5 tasks
|
@busunkim96 This happens to be exactly what I need for my gcloud auth file override work (where gcloud reads cred json files to create google-auth creds) |
arithmetic1728
approved these changes
Jun 17, 2020
|
@software-dov Please take another look, thanks! |
software-dov
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns
_load_credentials_from_fileinto a public methodload_credentials_from_file. Also allow scopes to be passed.On second thought, I'm not sure exposing this method this way is appropriate. Might be deceptive given that it isn't a magical method that can load all credentials 🤔